express-cdn
express-cdn copied to clipboard
Add Google Cloud Storage support
I read #70 but it would be useful to add support for Google Cloud Storage. What would it take to add another provider? I ask because there is now gcloud-node.
+1
@beriberikix @xpepermint a pull request for this would be awesome; I can't write it at the moment since I'm working on http://eskimo.io, however here are a few pointers:
- Modify
optionsobject to support aprovidername perhaps? (you need some way to detect if we need to useknoxor if we need to usegcloud-nodeto upload assets here https://github.com/niftylettuce/express-cdn/blob/master/lib/main.js#L439-L445 - In all (5) instances of
S3.putBuffer, replace or add a switch/case to use the proper provider that the user intends to use (e.g. https://github.com/niftylettuce/express-cdn/blob/master/lib/main.js#L178) - Add deprecation warning for users that are still using the old format for
options
Seems manageable. @proppy this would be pretty useful for our samples. WDYT?
@beriberikix +1