actions-on-google-java icon indicating copy to clipboard operation
actions-on-google-java copied to clipboard

Smarthome integration should expose DisconnectResponse

Open proppy opened this issue 5 years ago • 3 comments

Currently it seems that smarthome integration always returns an empty response for DisconnectRequest.

https://github.com/actions-on-google/actions-on-google-java/blob/master/src/main/kotlin/com/google/actions/api/smarthome/SmartHomeApp.kt#L166

This could be problematic as developer might need to return an errorCode when the DisconnectRequest is failing.

proppy avatar Jan 15 '20 08:01 proppy

According to the documentation there is no errorCode field for a DisconnectResponse type.

Fleker avatar Jan 15 '20 15:01 Fleker

Yes but https://developers.google.com/assistant/smarthome/develop/process-intents seems to indicate that most response could return errorCode

proppy avatar Jan 16 '20 04:01 proppy

This should be clarified more precisely. Even if the DisconnectResponse provided an error code, I don't believe the platform will interpret it. Regardless it seems like it'll disconnect the service.

Fleker avatar Jan 16 '20 15:01 Fleker