Marco Pracucci

Results 427 comments of Marco Pracucci

I would configure your Prometheus jobs to add the following labels: - cluster: name of the K8S cluster - job: "/" (eg. if Cortex is deployed in the "cortex-01" namespaces...

> Could you precise the job part ? The job label is a label that we expect to be added by Prometheus (configured in the Prometheus scraping config) whose value...

> Looks like @pracucci added this test, could you please take a look Marco? Yes, I'm looking into it.

The logs of the failing test execution are puzzling me because we get the log `switching partition state because enough owners have been registered and minimum waiting time has elapsed...

Looks a duplicate of https://github.com/grafana/mimir/issues/2676.

I agree. We've already done part of this renaming long time ago and the generic name we picked is "instance". When continuing this work we need to pay attention to...

I think it depends on a case by case basis. I agree with you that in some cases the stacked panel makes reading the data harder (eg. when you look...

What @pstibrany suggested sounds a reasonable solution to me. I would keep the init function restricted to the `flagext` package tho. If we make it generic, it's more likely we'll...

Thanks @amckinley for opening this PR and raising the discussion around gRPC message size limit. The current config is not an oversight, but we're aware of cases when the limit...

My concerns about exposing this config haven't changed, but I'm open to discuss it.