Marco Pracucci

Results 427 comments of Marco Pracucci

Same issue for the `cortexproject/cortex` (e.g. https://github.com/cortexproject/cortex/pull/4525). Does anyone know how to fix it (we would like to keep it enabled)?

It's a bit obscure, but I think you get it in practice running `mimir --modules=true`, because it validates the config and print modules, then exit.

I've just manually tested this PR and looks working great!

Can we see benchmarks? I would expect accessing the map being way slower than accessing the slice.

I've run the existing benchmarks this way: ``` git checkout main go test -run '^$' -bench '.*' -benchmem -count=3 ./pkg/ingester/activeseries > before.txt hub pr checkout 2568 go test -run '^$'...

@gubjanos I think the last comment from @colega was very valid. Are you still interested in following up with the suggestions from Oleg?

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase `main` and eventually move the CHANGELOG entry added / updated in this PR to the...

We should extend the doc introduced in https://github.com/grafana/mimir/pull/2347.

> Is there a way to use [Azure Blob CSI Driver](https://github.com/kubernetes-sigs/blob-csi-driver)? As I understand it won't be possible to use this due to multi-node filesystem limitation but in that case...

I would like to first learn which Mimir component would benefit from it.