dskit icon indicating copy to clipboard operation
dskit copied to clipboard

Rename `ingester` references inside dskit/ring package

Open DylanGuedes opened this issue 3 years ago • 2 comments
trafficstars

Not a biiig concern, but I noticed that dskit/ring mentions ingester everywhere. I think changing these mentions to something more generic is beneficial because at first glance isn't clear if that code was applied for all rings or just for the ingester.

DylanGuedes avatar Dec 15 '21 12:12 DylanGuedes

I agree. We've already done part of this renaming long time ago and the generic name we picked is "instance". When continuing this work we need to pay attention to not introduce breaking changes (eg. protobuf serialization, metric names, ...).

pracucci avatar Dec 15 '21 13:12 pracucci

@pracucci, @DylanGuedes I just went through dskit/ring and grepped ingester there are several lines of code where ingester is used, so do I need to rename each one of them to "instance" ?

Sheikh-Abubaker avatar Jan 13 '24 17:01 Sheikh-Abubaker