Marco Pracucci

Results 427 comments of Marco Pracucci

> > I would like to first learn which Mimir component would benefit from it. > > The compactor is currently the only component that calls the Thanos `block.Download()` method...

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase `main` and eventually move the CHANGELOG entry added / updated in this PR to the...

@dimitarvdimitrov Sorry, I didn't realise this PR and I just merged a PR upgrading dskit. Could you rebase `main`, please?

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase `main` and eventually move the CHANGELOG entry added / updated in this PR to the...

Could you add a CHANGELOG, please? :)

> albeit it won't catch CLI flags for monolithic mode but for those of us setting it in the config file it may still be a nice catch. Agree. The...

As a reference, a similar fix has been done for 429 errors in https://github.com/grafana/mimir/pull/2447.

mimirtool will be documented in https://github.com/grafana/mimir/pull/2481. @pstibrany is anything else left to document after #2481 will be merged?

>Once we add validation and (hopefully/possibly) This is already tracked by https://github.com/grafana/mimir/issues/2382.

Could you rebase again, please? :|