dskit icon indicating copy to clipboard operation
dskit copied to clipboard

Replace use of default registerer in flagext package

Open 56quarters opened this issue 4 years ago • 2 comments

We're trying to move away from global metrics since this is supposed to be a shared library. @pstibrany recommended potentially setting the register and logger with some sort of init method that could be called from an application's main function.

56quarters avatar Aug 30 '21 13:08 56quarters

What @pstibrany suggested sounds a reasonable solution to me. I would keep the init function restricted to the flagext package tho. If we make it generic, it's more likely we'll end up using global logger/registered in other places, which is something we want to strongly discourage.

pracucci avatar Sep 14 '21 07:09 pracucci

Agree we want to discourage use of global logger/metrics registerer.

aknuds1 avatar Sep 14 '21 07:09 aknuds1