Marco Pracucci

Results 427 comments of Marco Pracucci

> worth noting that there's another PR attempting to introduce HPA into the helm chart https://github.com/grafana/mimir/pull/4687 I'm closing this PR in favour of #4687 which looks has received more progress...

To use environment variables in the config, you have to enable the expansion as documented here: https://grafana.com/docs/mimir/latest/reference-configuration-parameters/#use-environment-variables-in-the-configuration However, you're right that in the page you're mentioning (`docs/sources/mimir/operators-guide/configure/configure-object-storage-backend.md`) we're not mentioning...

I think it's a matter of personal preference. I work on a relatively large screen and the current longer lines are not an issue for me.

I'm up to it, as far as it's optional. I would recommend to follow the same design used for query-scheduler ring.

> At some point in the future I'd like to add read-path request rate limits to the query-frontend so this would help with that 👍 I think it's a feature...

Thanks for working on this! Switching to draft until we get https://github.com/grafana/mimir/pull/4127 merged, since there's a pending comment there.

> store_gateway_client.go and store_gateway_test.go have been moved from the querier to the storegatewaypb package The `*pb` packages should contain only protobufs. That being said I don't think an integration should...

> Is there any chance to get the shardfunc onto Prometheus main? I feel we need to review any update to tsdb from now to check if it hardcodes using...

Comment on Slack from @colega: > I think that we need a test in compactor and other features that rely on the stability of the labels hash that checks that...

> > I think that we need a test in compactor and other features that rely on the stability of the labels hash that checks that given list of series...