Marco Pracucci comments

Results 427 comments of


                                            Marco Pracucci

Extract `UserRegistries` into http://github.com/grafana/dskit

They're non trivial to rebuild and I see value in them for other Grafana projects, so I have no objection in moving them to a shared lib.

query-frontend: During shut-down, wait on in-flight queries

> > Is it as easy to do something similar for frontend v1 too? > > @pracucci thanks, I wanted to ask if the same thing should be done for...

query-frontend: During shut-down, wait on in-flight queries

@aknuds1 I checked the frontend v1 code you shared and I think it waits until all inflight queries are done. > Should the above code be changed to just take...

query-frontend: During shut-down, wait on in-flight queries

> Should I finalize this PR by writing one or more tests? Yeah that would be great!

query-frontend: During shut-down, wait on in-flight queries

> I think there is a race condition in this approach Is it really important? How frequently could happen? We have a similar race in the querier graceful shutdown but...

query-frontend: During shut-down, wait on in-flight queries

> @pracucci after writing a timing based test, I realized that waiting on the `WaitGroup` in `Frontend.stopped` wasn't the best idea, since `stopped` gets called (by `BasicService`) after the service...

Querier tracks cortex_request_duration_seconds_count tracks status_code=503 on "context canceled"

The issue comes from the error mapping done in Prometheus API, specifically here: https://github.com/prometheus/prometheus/blob/ae597cac62425f0d3017860af6be5f65666c9e93/web/api/v1/api.go#L1602-L1603 When the context is canceled while running the PromQL engine then the HTTP response status code...