mimir icon indicating copy to clipboard operation
mimir copied to clipboard

querier: reformat some wide comments

Open bboreham opened this issue 2 years ago • 2 comments

I find it useful to be able to read comments in side-by-side diff view.

Checklist

  • NA Tests updated
  • NA Documentation added
  • NA CHANGELOG.md updated

bboreham avatar Feb 07 '23 17:02 bboreham

I think as long as there is no linter to enforce a line width, formatting comments bunch by bunch is a sisyphean task, sooner or later someone is going to undo it again. OTH I have no reason to block this PR.

replay avatar Feb 07 '23 17:02 replay

I think it's a matter of personal preference. I work on a relatively large screen and the current longer lines are not an issue for me.

pracucci avatar Feb 08 '23 11:02 pracucci

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

pstibrany avatar Mar 09 '23 09:03 pstibrany