Phil Quitslund

Results 122 issues of Phil Quitslund

The goal is to get more actionable information from users that are experiencing problems with performance.

area-analyzer
type-documentation
P2

Where possible, code that is generated by assists, fixes, refactorings and snippets should be idiomatic with respect to enabled lints. (For example, trailing commas should be inserted where appropriate, absolute...

P1
area-analyzer
analyzer-ux
analyzer-refactoring
analyzer-quick-fix
analyzer-snippet
analyzer-assist

Import quote style should agree with enabled lints. * `prefer_single_quotes` vs. * `prefer_double_quotes` I'm inclined to think the unspecified default should be single quotes (current behavior). /fyi @lrhn

area-analyzer
P3
analyzer-linter
analyzer-quick-fix

Follow-up from: https://github.com/dart-lang/linter/pull/3567#discussion_r934847261. As a general rule we want to encourage reflective tests over integration tests. It would be great to have some docs here.

type-documentation
type-code-health

It looks like a simple cache of the calculated packages (avoiding needless extra trips to process the pubspec) stand to make `depend_on_referenced_packages` twice as fast in our benchmarks. NOTE that...

type-performance
set-core

Now that we have reflective tests, we don't really need the existing integration tests so down the road we should remove them.

type-test
type-task
type-code-health
P4

#2648 introduces new diagnostics to libraries in (at least) 20 internal packages (the SDK roller stopped trying to add exceptions at 20). We'll need to investigate if these are false...

type-bug
customer-flutter
customer-google3
P2
false-negative
set-flutter

![image](https://user-images.githubusercontent.com/67586/114077446-ab1ab700-985c-11eb-8bde-1c8ad08abda2.png)

type-bug
customer: g3
false positive
set-flutter