Phil Quitslund

close_sinks rule false positive

35

_From @jaumard on November 20, 2018 12:37_ With the following code: ``` TransactionReceiptBloc() { final loadTransactionController = StreamController(sync: true); transactionId = loadTransactionController.sink; } void close() { transactionId.close(); } ``` dart...

[pub] (avoid) unsupported_properties

4

Follow-up from: https://github.com/dart-lang/pubspec_parse/issues/34#issuecomment-451094104, it would be interesting to have a rule that flagged unsupported pub properties. Among other things it would catch typos as observed by @jonasfj: > It's clear...

Lint: Avoid using function types as a runtime `Type`

2

_From @matanlurey on November 13, 2018 1:29_ _I don't know how this lint request will interact with the generalized typedef language proposals_ In Dart 2.x, `typedef` relates directly to its...

From the [Doc Comment Guidelines](https://www.dartlang.org/articles/doc-comment-guidelines/#first-paragraph-a-one-sentence-description): **DO** end the first paragraph of your doc comment (the summary) with a period (`.`). The first paragraph of a doc comment is special. After...

proposal: `no_redundant_default_values `

3

## no_redundant_default_values ## Description Avoid redundant default values. ## Details DON'T declare parameters with default values that match existing defaults. Declarations that repeat default values are redundant and unnecessary. In...

ensure `no_duplicate_case_values` works with switch-expressions

4

https://github.com/dart-lang/language/blob/master/working/0546-patterns/patterns-feature-specification.md#switch-expression

Deprecate (and remove) `traverseNodesInDFS`

1

This utility method has been the root of some pathologically bad performance (https://github.com/dart-lang/linter/issues/3706, https://github.com/dart-lang/linter/issues/505) but is not great even in the common case. As a rule, there's always a better...

🚧 reduce iteration in `directives_ordering` (WIP)

1

(WIP)

proposal: extend `unawaited_futures` to catch discarded futures when upcast to void

7

## extend `unawaited_futures` to catch discarded futures when upcast to `void` ## Description Future results upcast to `void` are not awaited. ## Details Future results upcast to `void` are not...

/cc @patefacio