Phil Quitslund

A meta-issue to discuss and track server work on quick assists and fixes for [patterns](https://github.com/dart-lang/language/blob/master/working/0546-patterns/patterns-feature-specification.md). **CorrectionProducers to Review/Test/Update** - [ ] `RemoveDuplicateCase` - [ ] `UseCurlyBraces`

[records] parse errors when trying to annotate a record type class field

35

The following code generates what look like parser errors.  ``` error: Annotation must be either a const variable reference or const constructor invocation. (invalid_annotation at [sandbox] lib/public.dart:27) error: Variables...

consider `list_comprehensions` lint

4

Follow-up from https://github.com/flutter/devtools/pull/1837#discussion_r411544355, where @jacobr suggested: > nit: consider using List comprehensions for this case instead of map followed by toList(). > this might be a reasonable general lint to...

lint to protect against SQL injection (package:sqflite)

2

**Ensure that SQL query strings are always constant, or use whitelisted string-interpolation methods.** Specifically guard against unsafe use of [package:sqflite](https://github.com/tekartik/sqflite/tree/master/sqflite). _(Placeholder. Details to follow.)_

lint to flag default clauses in enum-like switch statements

15

**Avoid default clauses in enum-like switch statements** Good: ```dart switch (testEnum) { case TestEnum.A: return '123'; case TestEnum.B: return 'abc'; } // Default here. return null; ``` Bad: ```dart switch...

lint to disallow storage of internationalized strings to static finals

12

To enable runtime language selection, results from calling `Intl.message` should not be stored in static final, or objects that hold them.

annotation and lint to support unmodifiable lists

1

See this fix for a place this would have been handy: https://dart-review.googlesource.com/c/sdk/+/121862 /fyi @stereotype441 @srawlins

TL;DR: add lints to lint rules in analysis options that duplicate included rules (e.g., pedantic). More context in https://github.com/dart-lang/pedantic/issues/23, where @kentcb wrote: > Here's my situation: I want to use...

From the linter pana report: 

lint request: enforce recommended dartdoc structure

11

In https://github.com/flutter/flutter/pull/27791#discussion_r255772365, @goderbauer wrote: > That a dartdoc should start with a one-sentence summary as its own paragraph is something I have to frequently point out in code reviews -...