Phil Quitslund

Results 122 issues of Phil Quitslund

This was "fixed" recently in https://github.com/dart-lang/linter/commit/67a270f5e341a5771410f455214868eee954da8f and some flutter packages are cleaned up in https://github.com/flutter/flutter/pull/127211 but it was a roll blocker due to lots of flutter ecosystem breakages. (See, for...

type-bug
P2
false-negative
set-flutter-dev

Tracking issue for newly added quick fixes. ## Diagnostics with newly added fixes - [x] `EXPECTED_CATCH_CLAUSE_BODY` @pq - [x] `EXPECTED_CLASS_BODY` @pq - [x] `EXPECTED_EXTENSION_BODY` @pq - [x] `EXPECTED_EXTENSION_TYPE_BODY` @pq -...

area-analyzer
analyzer-quick-fix
P2
type-enhancement

area-analyzer
analyzer-quick-fix
P2
type-enhancement
feature-wildcard-variables

We might consider a lint to encourage the use of [switch-expression](https://github.com/dart-lang/language/blob/master/working/0546-patterns/patterns-feature-specification.md#switch-expression)s. **BAD** ```dart Color shiftHue(Color color) { switch (color) { case Color.red: return Color.orange; case Color.blue: return Color.purple; case Color.green:...

type-enhancement
P2
new-language-feature
lint-proposal
status-pending

## no_nullable_values_in_interpolated_strings ## Description Do not use nullable values in interpolated strings. ## Details TODO: See: https://github.com/dart-lang/language/issues/2053. ## Kind Error ## Good Examples ```dart void main() { String test =...

type-enhancement
P3
lint-proposal
status-pending

### Name: avoid_non_null_checks **Description:** Avoid using non-null-check operators. **Details:** Code that uses non-null-check operators (`!`) is harder to understand and can lead to runtime exceptions. In general, you should avoid...

type-enhancement
P3
lint-proposal
status-pending

As per the discussion in https://github.com/dart-lang/linter/issues/4968, we want to start reporting `UNUSED_LOCAL_VARIABLE` for non wildcard underscore cases (e.g., `__`, `___`, etc). **UPDATE:** non-wildcard underscores will produce diagnostics but whether we...

area-analyzer
analyzer-warning
P2
type-enhancement
feature-wildcard-variables

Follow-up from: https://github.com/dart-lang/sdk/issues/55721#issuecomment-2113263991, It'd be nice to have a fix (or at least assist) that removes the unnecessary stack catch in code like: ```dart try { } catch(e, _) {...

area-analyzer
analyzer-quick-fix
P2
type-enhancement
type-question

At some point I had confidence that we'd want such a conversion but I think I mistook an `UNUSED_LOCAL_VARIABLE` diagnostic for an `UNUSED_ELEMENT`. @bwilkerson, @kallentu: can you think of any...

area-analyzer
analyzer-quick-fix
P2
type-enhancement
feature-wildcard-variables

Consider highlighting wildcards specially (see [discussion](https://dart-review.googlesource.com/c/sdk/+/382042/2/pkg/analysis_server/test/lsp/hover_test.dart#285)). @scheglov: as someone who enjoys semantic highlighting, I'd be especially curious to get your perspective. Would this be valuable? Too much noise? Too difficult...

area-analyzer
analyzer-server
analyzer-ux
P2
feature-wildcard-variables