Patrick Ohly
Patrick Ohly
/hold Needs to be reviewed together with https://github.com/kubernetes-sigs/kind/pull/4015. This PR then needs to be merged first.
/assign @BenTheElder @dims: this changes some of your jobs. Do you agree that including serial tests makes sense for them? @aojea: same with your network jobs. You expressed a desired...
> Maintaining two variants is more work and makes the testgrid dashboards larger. I think that's done for jobs not using LABEL_FILTER yet. There is a `ci-kubernetes-kube-network-policies-conformance-parallel` but no corresponding...
/ok-to-test /sig node
/hold Might be better done as a canary in https://testgrid.k8s.io/sig-testing-canaries.
@yliaog: bug fixes need a release note that is sufficient for normal users to understand what was fixed.
> When the controller starts, 2 sync() call will run simultaneously, one from HasSynced(), another from processNextWorkItem(). Each will produce an instance for the same topology segment, and pass it...
> Yes, I think this controller is designed to only run one worker `RunWorker` executes one worker, but could be invoked more than once. Where is it called?
It wasn't designed to be run only once, that's just only how it's currently being done. But as that apparently is sufficient, the fix can be pretty simple: - document...
> Then we will lost the ability of syncing partial data from upstream controllers. Not sure if this is good. It's normal that controllers wait for a full cache sync...