Patrick Ohly

Results 1004 comments of Patrick Ohly

/test pull-kubernetes-e2e-kind-alpha-beta-features-race

it also failed in other jobs: https://storage.googleapis.com/k8s-triage/index.html?text=unexpected%20exit%20code%202&test=Pods%20Extended%20Pod%20Container%20Status%20should%20never%20report%20success%20for%20a%20pending%20container

/close In favor of https://github.com/kubernetes/kubernetes/issues/135713. Also reported in https://github.com/kubernetes/kubernetes/issues/129800, which was closed already without a resolution.

/test pull-kubernetes-dra-integration

Unrelated, just testing the jobs: /test pull-kubernetes-kind-dra-n-2 pull-kubernetes-kind-dra-n-1

We don't use GitHub actions for golangci-lint, but updating to the latest makes sense by itself.

Here's a PR enabling another linter: https://github.com/kubernetes/kubernetes/pull/135530 Your PR which enabled go critic's deprecatedComment was merged: https://github.com/kubernetes/kubernetes/pull/133571 The version bump here makes that linter a bit more precise.

Rebased because 1f1d197701de6deb3641dd8df5bc4452a2949361 touched some of the same lines when removing usegocmp. Can someone re-add LGTM?

/skip https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/135531/pull-kubernetes-e2e-kind-kms/2001665602808188928