Patrick Ohly

Results 1004 comments of Patrick Ohly

I was reminded that we have https://github.com/kubernetes/kubernetes/tree/master/test/e2e/kubectl because of https://github.com/kubernetes/kubernetes/pull/133931. E2E tests are supposed to test the cluster, not the client, and therefore testing kubectl in E2E is a bit...

> we could first shift as much kubectl logic as possible into Go unit tests, covering flag parsing, argument handling, defaulting, and internal behaviors Isn't that something that already exists...

I don't have a strong opinion about which tests are suitable to be only unit tests. But I'd like to point out that even with unit tests, verifying the same...

/test pull-kubernetes-integration-dra

/test pull-kubernetes-dra-integration

/test pull-kubernetes-dra-integration

/test pull-kubernetes-dra-integration

/test pull-kubernetes-dra-integration

/test pull-kubernetes-dra-integration

/test pull-kubernetes-local-e2e Known to be broken because of kubekins image issues. I'm just starting it to verify.