Patrick Ohly

Results 1006 comments of Patrick Ohly

@mmorel-35: does this include all fixes for this particular check? As @ffromani noted, this already covers several different SIGs. If there are similar fixes for other SIGs, then let's also...

> This includes all fixes for Len and empty rules of testifylint in pkg package So there might be other fixes related to that elsewhere? Better include those, too. >...

Once this PR is merged, does it get rolled out to our Prow instance automatically?

Does this mean that we can remove the e2e.test's `-progress-report-url` feature (https://github.com/kubernetes/kubernetes/blob/4e8b192b66cc2a6952b8f1a5067e563c4019c276/test/e2e/framework/test_context.go#L386)? I was told that Sonobuoy uses it, but when I asked about details and whether it actually works...

> Should we also update the pull-kubernetes-e2e-kind job using the LABEL_FILTER? Yes, please go ahead and do that. It won't be sufficient to unblock this PR, though.

> wht those alpha tests are running in presubmit? Because the presubmit has not been updated to use --label-filter. /hold This PR can only be merged after all jobs are...

/retitle WIP: remove unneeded e2e features

/remove-lifecycle rotten

/test pull-kubernetes-e2e-kind-beta-features

> Is there any existing documentation or resources that we can empower contributers to reference to for setting initial values then iterating? Or should we expect the sig maintainters and...