Patrick Ohly
Patrick Ohly
When I started working on some conversion to v1beta2 in our code, I realized that we hadn't actually added that to the docs. It's not directly related to device taints,...
It might be worth checking more thoroughly what `go test -bench -json` produces, if time permits. As a hotfix this seems okay.
In https://github.com/gotestyourself/gotestsum/pull/438#issuecomment-2354059302 you said that this PR "is the right fix for" https://github.com/gotestyourself/gotestsum/issues/413. I'm not sure whether that means that it should already be fixed or whether this approach will...
You can edit the target branch of a GitHub PR.
> For types that define String() - should we prefer that or JSON? I chose JSON, but it changes some results. At first glance, this seems like a situation where...
> one can read from left to right and figure out what the value is without quoting it Except that there is more text after the value: ``` path.to.field: Invalid...
Apropos error rendering: should or shouldn't validation tests check for expected errors by comparing against full strings, check for more or less complete sub-strings, or against errors produced by calling...
> where the value is (for example) a whole container So that's exactly the case where ignoring the `fmt.Stringer` implementation in favor of some nicer rendering makes sense. I sometimes...
I want my error matching to be pretty complete, but the "origin instead of detail string" is nice. I converted pkg/apis/resource/validation, which included making some changes elsewhere - see https://github.com/kubernetes/kubernetes/pull/132577
@lauralorenz: do you want to finish this?