prow icon indicating copy to clipboard operation
prow copied to clipboard

Enhance testfreeze plugin to distinguish Code Freeze and Test Freeze

Open saschagrunert opened this issue 1 week ago • 3 comments

The testfreeze plugin now separately detects and reports on Code Freeze and Test Freeze phases, which can occur independently.

Code Freeze detection:

  • Checks kubernetes/test-infra Prow Tide configuration
  • Detects when release branch is excluded from automatic merges

Test Freeze detection:

  • Uses existing logic: release branch exists without .0 tag

Comment behavior:

  • Code Freeze: Shows milestone approval requirements with clear process:
    1. Technical review: PR must be reviewed and approved as usual (/lgtm and /approve)
    2. Inclusion in release: Contributors ping sig-release-leads on sig-release Slack channel to request milestone addition Pings release-team-leads and release-managers teams
  • Test Freeze: Shows fast-forward information
  • Both active: Shows both sections with appropriate guidance

This addresses the documentation gap where contributors need clear guidance on milestone management during Code Freeze, with specific instructions on how to reach the Release Team for approval.

/cc @kubernetes-sigs/release-engineering /hold for discussion

Fixes https://github.com/kubernetes-sigs/prow/issues/557

saschagrunert avatar Nov 26 '25 11:11 saschagrunert

@saschagrunert: GitHub didn't allow me to request PR reviews from the following users: kubernetes-sigs/release-engineering.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

The testfreeze plugin now separately detects and reports on Code Freeze and Test Freeze phases, which can occur independently.

Code Freeze detection:

  • Checks kubernetes/test-infra Prow Tide configuration
  • Detects when release branch is excluded from automatic merges

Test Freeze detection:

  • Uses existing logic: release branch exists without .0 tag

Comment behavior:

  • Code Freeze: Shows milestone approval requirements, pings @kubernetes/release-team-leads and @kubernetes/release-managers
  • Test Freeze: Shows fast-forward information
  • Both active: Shows both sections with appropriate guidance

This addresses the documentation gap where contributors need clear guidance on milestone management during Code Freeze.

/cc @kubernetes-sigs/release-engineering /hold for discussion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Nov 26 '25 11:11 k8s-ci-robot

Deploy Preview for k8s-prow ready!

Name Link
Latest commit be0f38baffe69b4c2a0147425e31ad794cc2a830
Latest deploy log https://app.netlify.com/projects/k8s-prow/deploys/69305099f370c40008143a07
Deploy Preview https://deploy-preview-558--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Nov 26 '25 11:11 netlify[bot]

@jenshu: GitHub didn't allow me to request PR reviews from the following users: release-managers.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @release-team-leads @release-managers

should these be the slack group handles?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Dec 01 '25 20:12 k8s-ci-robot

@pohly: GitHub didn't allow me to request PR reviews from the following users: release-managers.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Huh? We cannot /cc Slack handles in GitHub. The following doesn't work:

/cc @release-team-leads @release-managers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Dec 02 '25 07:12 k8s-ci-robot

/retest

saschagrunert avatar Dec 02 '25 08:12 saschagrunert

/lgtm

jenshu avatar Dec 03 '25 14:12 jenshu

/unhold

saschagrunert avatar Dec 03 '25 14:12 saschagrunert

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 03 '25 15:12 k8s-ci-robot

/lgtm

/unhold

saschagrunert avatar Dec 03 '25 15:12 saschagrunert

Once this PR is merged, does it get rolled out to our Prow instance automatically?

pohly avatar Dec 03 '25 15:12 pohly

Once this PR is merged, does it get rolled out to our Prow instance automatically?

I assume that, yes.

saschagrunert avatar Dec 03 '25 15:12 saschagrunert