website
website copied to clipboard
kubernetes
DRA: device taints and tolerations
Deploy Preview for kubernetes-io-vnext-staging processing.
| Name | Link |
|---|---|
| Latest commit | 779aeebb8a836fd355578b51e70475e9220cad17 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67f64c4d1d67260008c1d885 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 779aeebb8a836fd355578b51e70475e9220cad17 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67f64c4db2db350008033dc8 |
| Deploy Preview | https://deploy-preview-49822--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@pohly: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.
In response to this:
/milestone v1.33
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@pohly: Closed this PR.
In response to this:
/close
Did not go into 1.33.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@pohly: Reopened this PR.
In response to this:
/reopen
Still needed for KEP 5055.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Hello @pohly :wave:! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!
@nojnhuh, @everpeace: I pushed an update which should address your comments, please take another look.
LGTM label has been added.
@rayandas: GitHub didn't allow me to assign the following users: lmktfy.
Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
/assign @lmktfy As sftim is now lmktfy.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nojnhuh, tengqm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~content/en/docs/OWNERS~~ [tengqm]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@lmktfy The suggested changes are now addressed. Could you please give an lgtm?
Hello 👋, 1.33 Docs team here. This PR did not meet deadline for docs freeze. Enhancements without required documentation may be removed from the current release. If you still wish to include this enhancement in 1.33, please file an exception request. Thanks!
I rebased.
The guidelines for code PRs which have LGTM+Approve and then don't merge because of a code conflict or technical problems in the CI pipeline is that they can be rebased without having to ask for an exception. Can we please apply the same here?
This didn't quite have LGTM after the final review, but almost and should have been ready.
Hi @pohly thanks for updating the PR. @nojnhuh @everpeace could you please give another lgtm? Then I will consider this PR as tracked and it doesn't require an exception. Thanks!
When I started working on some conversion to v1beta2 in our code, I realized that we hadn't actually added that to the docs. It's not directly related to device taints, but as this PR is the last remaining PR for DRA for 1.33, let's rectify that omission here.
At least one example wasn't actually valid. I verified all of them with kubectl create --dry-run.
LGTM label has been added.
It's not directly related to device taints, but as this PR is the last remaining PR for DRA for 1.33, let's rectify that omission here. At least one example wasn't actually valid. I verified all of them with kubectl create --dry-run.
@pohly I'm verry sorry that I missed your the last comment before my putting /lgtm to this PR. You will need to create another PR to fix this🙇 sorry for the disturbance 🙇