Patrick Ohly
Patrick Ohly
/remove-lifecycle stale /lifecycle frozen
/wg device-management
/reopen Please continue with the annual report... :sweat_smile:
The deletion of namespaces created by the test happens in another DeferCleanup: https://github.com/kubernetes/kubernetes/blob/7ec344dcef9a04920578aabe4e122bc0b3404afe/test/e2e/framework/framework.go#L215 That one should get registered before the cleanup of the ClusterRoleBinding, and thus should run last. I...
Regarding unit tests: - I prefer using stretchr/testify over manually written failures. - I prefer `map[string]struct` for sub-tests (guaranteed unique test name as key). - Use `klog/ktesting` to get a...
/pull pull-kubernetes-e2e-kind-canary Testing LABEL_FILTER, please ignore.
/test pull-kubernetes-e2e-kind-canary
``` panic: test timed out after 3m0s running tests: TestRoundtripToUnstructured (1m24s) TestRoundtripToUnstructured/v1.admissionregistration.k8s.io/ValidatingAdmissionPolicyBinding (0s) ``` /retest /assign @klueska For approval.
/lgtm /assign @dims @testwill: thanks for the PR. But remember that even trivial changes have a cost, so perhaps next time think about whether it's really necessary to change the...
/remove-lifecycle stale