enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

DRA: Add support for partitionable devices

Open klueska opened this issue 1 year ago โ€ข 8 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add support for partitionable devices to DRA.

  • Kubernetes Enhancement Proposal:

    • https://github.com/kubernetes/enhancements/issues/4815
    • https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4815-dra-partitionable-devices
  • Discussion Link:

    • https://github.com/kubernetes-sigs/wg-device-management/issues/20#issuecomment-2168189769
    • https://github.com/kubernetes-sigs/wg-device-management/pull/29
    • https://github.com/kubernetes-sigs/wg-device-management/pull/30
    • https://github.com/kubernetes-sigs/wg-device-management/pull/31
    • https://github.com/kubernetes-sigs/wg-device-management/pull/32
    • https://github.com/kubernetes-sigs/wg-device-management/pull/35
  • Primary contact (assignee): @klueska, @pohly, @johnbelamaric, @thockin

  • Responsible SIGs: /sig node

  • Enhancement target (which target equals to which milestone):

    • Alpha release target: 1.32
    • Beta release target: 1.33
    • Stable release target: 1.34
  • [ ] Alpha

    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4874
    • [ ] Code (k/k) update PR(s):
      • TBD
    • [ ] Docs (k/website) update PR(s):
      • https://github.com/kubernetes/website/pull/48530

klueska avatar Aug 30 '24 09:08 klueska

/sig node

kannon92 avatar Aug 30 '24 11:08 kannon92

/milestone v1.32 /label lead-opted-in

haircommander avatar Sep 17 '24 18:09 haircommander

Hello @klueska ๐Ÿ‘‹, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise)

/stage alpha

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: v1.32.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • Create the KEP readme using the latest template and merge it in the k/enhancements repo.
  • Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

dipesh-rawat avatar Sep 24 '24 22:09 dipesh-rawat

Hi @klueska ๐Ÿ‘‹, v1.32 Enhancements team here.

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

The current status of this enhancement is marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/4815#issuecomment-2372526115 that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

dipesh-rawat avatar Oct 08 '24 17:10 dipesh-rawat

@klueska Now that PR https://github.com/kubernetes/enhancements/pull/4874 has been merged, all the KEP requirements are in place and merged into k/enhancements.

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

dipesh-rawat avatar Oct 10 '24 13:10 dipesh-rawat

Hi @klueska ๐Ÿ‘‹, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

chanieljdan avatar Oct 12 '24 02:10 chanieljdan

Hi @klueska ๐Ÿ‘‹, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @klueska ๐Ÿ‘‹,

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is a week away at Thursday October 24, 2024 18:00 PDT.

Thanks,

Daniel

chanieljdan avatar Oct 17 '24 14:10 chanieljdan

Hey again @klueska ๐Ÿ‘‹ v1.32 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

Here's where this enhancement currently stands:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

I searched k/k and couldnโ€™t find any recent PRs related to this KEP.

@klueska Please let me know the PRs in k/k that are not listed in the description or not linked with this GitHub issue that we need to track for this KEP, so that we can maintain accurate status.

The status of this enhancement is marked as at risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

dipesh-rawat avatar Oct 21 '24 01:10 dipesh-rawat

๐Ÿ‘‹ Hi there, William here from v1.32 Comms We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

wrkode avatar Oct 24 '24 16:10 wrkode

Hey again @klueska ๐Ÿ‘‹, v1.32 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in few days, at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

The current status of this enhancement is marked as at risk for code freeze. There are a few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/4815#issuecomment-2425354220 that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance.

dipesh-rawat avatar Nov 05 '24 01:11 dipesh-rawat

Hello @klueska ๐Ÿ‘‹ v1.32 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.32 milestone.

If you still wish to progress this enhancement in v1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/label tracked/no /remove-label tracked/yes /milestone clear

dipesh-rawat avatar Nov 08 '24 02:11 dipesh-rawat

/wg device-management

pohly avatar Nov 19 '24 16:11 pohly

/sig scheduling

johnbelamaric avatar Jan 09 '25 17:01 johnbelamaric

Hello @klueska ๐Ÿ‘‹, 1.33 Enhancements Lead here.

If you'd like to work on this enhancement in v1.33, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.33 using /milestone v1.33. Thanks!

/remove-label lead-opted-in

dipesh-rawat avatar Jan 13 '25 11:01 dipesh-rawat

/label lead-opted-in

Huang-Wei avatar Feb 06 '25 06:02 Huang-Wei

Hello @klueska ๐Ÿ‘‹, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: v1.33.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

bianbbc87 avatar Feb 10 '25 23:02 bianbbc87

Hi ! Please change the latest-milestone and alpha milestone of kep.yml to v1.33.

bianbbc87 avatar Feb 10 '25 23:02 bianbbc87

Hi ! Please change the latest-milestone and alpha milestone of kep.yml to v1.33.

See #5066 - I think that will merge soon.

johnbelamaric avatar Feb 11 '25 16:02 johnbelamaric

@klueska With PR https://github.com/kubernetes/enhancements/pull/5066 covered most of the updates we need for inclusion of this KEP in v1.33.

Could I get a bit more clarification before we set the status of the KEP? In the issue description, I see another PR https://github.com/kubernetes/enhancements/pull/5069 that modifies the KEP files and hasnโ€™t been merged. Can one of the KEP contributors confirm if that PR isnโ€™t part of the current release work and is something weโ€™re doing incrementally for future? Maybe @johnbelamaric, you can help with this question. Apologies for the ping and any confusion!

dipesh-rawat avatar Feb 12 '25 21:02 dipesh-rawat

Hi, yes, we do hope to add the work in #5069 in this release as well, but we would proceed with what we have if there is some issue with that. I expect (hope!) that will merge tomorrow when our European contributors have had a chance to review it.

johnbelamaric avatar Feb 12 '25 22:02 johnbelamaric

Hello @klueska @mortent ๐Ÿ‘‹, 1.33 Enhancements team here.

Now that PRs https://github.com/kubernetes/enhancements/pull/5069 https://github.com/kubernetes/enhancements/pull/5066 has been merged, all the KEP requirements are in place and merged into k/enhancements.

Before the enhancement freeze, it would be appreciated if following nit could be addressed:

  • Update issue description to add the correct link for KEP readme (the current link is broken).
    • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/4815-dra-partitionable-devices/README.md

Aside from the minor nit mentioned above, this enhancement is all good for the upcoming enhancements freeze. ๐Ÿš€

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you! (cc: @bianbbc87)

/label tracked/yes

dipesh-rawat avatar Feb 13 '25 18:02 dipesh-rawat

Hello @klueska @mortent :wave:, v1.33 Docs Lead here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

rayandas avatar Feb 23 '25 10:02 rayandas

Docs placeholder PR: https://github.com/kubernetes/website/pull/49868

mortent avatar Feb 23 '25 16:02 mortent

Thanks @mortent Please add it in the issue description as well.

rayandas avatar Feb 24 '25 04:02 rayandas

/assign

mortent avatar Feb 27 '25 23:02 mortent

Hey @klueska, @pohly, @johnbelamaric, and @thockin ๐Ÿ‘‹ -- this is Udi (@Udi-Hofesh) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features that fall into (but are not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail ๐ŸŽ‰

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines ๐Ÿ“š

[!Tip] Some timelines to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

[!Note] In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Udi-Hofesh avatar Mar 01 '25 10:03 Udi-Hofesh

@Udi-Hofesh I have created a placeholder PR for a feature blog about this feature: https://github.com/kubernetes/website/pull/49994. We might want to make a single blog covering both partitionable devices and prioritized list, but I've created separate placeholder PRs for now.

@klueska Could you add links to both the docs and blog placeholder PRs in the issue description (I don't have permissions to edit it):

  • Docs PR: https://github.com/kubernetes/website/pull/49868
  • Blog PR: https://github.com/kubernetes/website/pull/49994

mortent avatar Mar 04 '25 04:03 mortent

Hey again @klueska ๐Ÿ‘‹, v1.33 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

  • Ensure all PRs to the Kubernetes repo related to your enhancement are linked in the above issue https://github.com/kubernetes/enhancements/issues/1710#issue-605665587 (for tracking purposes).
  • Ensure all PRs are prepared for merging (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

bianbbc87 avatar Mar 04 '25 05:03 bianbbc87

Hey again @klueska @mortent ๐Ÿ‘‹, v1.33 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

  • https://github.com/kubernetes/kubernetes/pull/130764

Additionally, please let me know if there are any other PRs in k/k not listed above that we should track for this KEP, so that we can maintain accurate status.

If you anticipate missing code freeze, you can file an exception request in advance. The status of this enhancement is marked as At risk for code freeze.

As always, we are here to help if any questions come up. Thanks!

bianbbc87 avatar Mar 04 '25 06:03 bianbbc87

@Udi-Hofesh I have created a placeholder PR for a feature blog about this feature: kubernetes/website#49994. We might want to make a single blog covering both partitionable devices and prioritized list, but I've created separate placeholder PRs for now.

@klueska Could you add links to both the docs and blog placeholder PRs in the issue description (I don't have permissions to edit it):

Perfect @mortent thank you!

Udi-Hofesh avatar Mar 04 '25 19:03 Udi-Hofesh