Patrick Ohly
Patrick Ohly
This PR now seems to be in an intermediate state. Either add using `context.Context` and fix whatever problems arise, or don't add it and just add a logger to the...
It would be nicer to get rid of that `context.background` in https://github.com/kubernetes/kubernetes/blob/7df5940bf920349a3c158bcd425e4e4cf97096da/pkg/kubelet/pleg/generic.go#L223. But that means addressing all problems around context handling. I thought that was seen as too complicated?
Yes. Pass just the logger and leave out the context changes.
> As the feature gate is enabled by default, they will be executed in e2e tests. No, they won't, because of the `feature.RelaxedEnvironmentVariableValidation` label. You need to set up jobs...
Yes, exactly that. In my experience, `unique.Make` can be expensive. But if it is done once and the result is used often, it pays off. Using internalized strings might have...
/test pull-kubernetes-csi-release-tools-csi-test
/lgtm /approve The pull-kubernetes-csi-release-tools-csi-test failure will get fixed by https://github.com/kubernetes-csi/csi-test/pull/561.
> The AllocatedDeviceStatus has been extended to contain two new fields: Not just that, the entire `claim.status.deviceStatuses` field is new. Who writes that field? I see in https://github.com/LionelJouin/kubernetes/commits/dra-device-status/ that you...
> I used the kubelet kubeconfig to access the Kubernetes API (as for simplicity since Containerd was not using the Kubernetes API before). So it wasn't kubelet itself, thus avoiding...