Patrick Ohly

Results 1006 comments of Patrick Ohly

/test pull-kubernetes-apidiff Might have died because of OOM.

Some description of what problem this change addresses would be useful. Both commit message and PR description are empty.

@mortent: please address the comments and rebase.

/retitle WIP: Add instructions for running the example driver on GKE

Perhaps you can use https://pkg.go.dev/k8s.io/klog/v2#SetOutputBySeverity?

There are no klog flags for what you want to achieve and given that klog is considered in feature freeze, I also don't want to add some. If you find...

Looks reasonable. Can you clean up the commits? One for the tests.yaml and one for the code changes?

Merged via https://github.com/go-logr/zapr/pull/87 (separate commit, author preserved).

Prioritized Alternatives has no impact on the driver, or no impact that would need a feature gate (it might have to handle sub-request names, but I forgot the details -...