arrow icon indicating copy to clipboard operation
arrow copied to clipboard

chore: Set permissions for GitHub actions

Open naveensrinivasan opened this issue 3 years ago • 5 comments

Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

  • Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests

Signed-off-by: naveen [email protected]

naveensrinivasan avatar Jul 04 '22 00:07 naveensrinivasan

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

github-actions[bot] avatar Jul 04 '22 00:07 github-actions[bot]

Thanks, this is a good change. This is not a minor PR by our definition so please create a JIRA ticket for it :)

assignUser avatar Jul 04 '22 12:07 assignUser

Thanks, this is a good change. This is not a minor PR by our definition so please create a JIRA ticket for it :)

I will do that. Thanks

naveensrinivasan avatar Jul 04 '22 16:07 naveensrinivasan

@naveensrinivasan Ping! Could you create a JIRA ticket as requested? If you are not able to do it, please say so so that someone else can step up :-)

pitrou avatar Aug 08 '22 15:08 pitrou

@naveensrinivasan Ping! Could you create a JIRA ticket as requested? If you are not able to do it, please say so so that someone else can step up :-)

I apologize. I won’t be able to do it now.

naveensrinivasan avatar Aug 08 '22 16:08 naveensrinivasan

I will pick this up in ARROW-17621

assignUser avatar Sep 05 '22 16:09 assignUser