Chris Pinkenburg

I had a look at the failure - we cannot have any dependencies on other libraries here. That can be overcome by moving those classes to ffarawobjects. But looking at...

The code still creates a memory leak: https://web.sdcc.bnl.gov/jenkins-sphenix/job/sPHENIX/job/test-default-valgrind-CaloProduction-Year1/961/valgrindResult/pid=266268,0x1d500/ the packet allocated in CaloTowerBuilder.cc:201 is seemingly not deleted (at least not in all cases)

Shuhang fixed the memory leak but he made significant changes (removal of code duplications) to the CaloTowerBuilder. It might be easier to start again from scratch than to resolve the...

clang tidy issues can be fixed automatically by: clang-tidy *.cc --fix -- -Wall -Werror -Wshadow -std=c++17 -Wno-dangling -isystem$OFFLINE_MAIN/include -isystem$ROOTSYS/include -isystem$G4_MAIN/include -isystem$G4_MAIN/include/Geant4 -isystem$OPT_SPHENIX/include -DHomogeneousField -DEVTGEN_HEPMC3 -DRAVE -DRaveDllExport= this messes up te...

Hi Mariia, don't worry about the failures - I am using your PR to try a few things. Once I am done I'll merge this

The valgrind error is just a shifted line number of a known issue, it's now in the suppression file

something went badly wrong, putting this PR on ice for the time being

PHParameters are very expensive to use on an event by event basis. They are meant to be used for configurations and have a DB backend. This is just the wrong...

That was a bit of a temporary measure - before that they used PHFlag which is even worse. The very basic problem here (and in the jet background) is that...

This PR misses the include file. It passed jenkins because it was not in the packages.txt, so jenkins did not try to compile this. I just added it to the...