Fix g4tpc

[pinkenburg]

Types of changes

• [X ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work for users)
• [ ] Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• [x] I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

This PR takes care of the various clang-tidy warnings in g4tpc

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

[sphenix-jenkins-ci[bot]]

Build & test report

Report for commit 1df3a7ea57db7f39f14d7323e59da321a507dfb7:

• builds and tests overall are SUCCESS.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, :bar_chart:Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 14.182 / 72, and combined p-Value = 1
    • :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.0581 / 72, and combined p-Value = 0.992606
    • :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.6655 / 42, and combined p-Value = 0.941883
    • :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 9.21446 / 42, and combined p-Value = 1
  • Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • :bar_chart: QA-Tpc : combined Chi2/nDoF = 840 / 56, and combined p-Value = 2.60523e-140
    • :bar_chart: QA-tracking : combined Chi2/nDoF = 776.616 / 56, and combined p-Value = 1.82783e-127
    • :bar_chart: QA-vertexing : combined Chi2/nDoF = 1743.07 / 112, and combined p-Value = 1.37043e-290
  • Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
    • :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • :bar_chart: QA-Tpc : combined Chi2/nDoF = 877.072 / 56, and combined p-Value = 7.42901e-148
    • :bar_chart: QA-tracking : combined Chi2/nDoF = 745.165 / 50, and combined p-Value = 1.36462e-124
    • :bar_chart: QA-vertexing : combined Chi2/nDoF = 680.426 / 112, and combined p-Value = 2.92577e-82
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
• clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
• cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration            

[pinkenburg]

something went badly wrong, putting this PR on ice for the time being

[osbornjd]

This can be the poster child showing clang-tidy actually does find problems in code...