coresoftware
coresoftware copied to clipboard
DRAFT PR DO NOT MERGE: Adding TpcTpotEventInfo to the pool manager
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work for users)
- [ ] Requiring change in macros repository (Please provide links to the macros pull request in the last section)
- [x] I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)
What kind of change does this PR introduce? (Bug fix, feature, ...)
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)
Build & test report
Report for commit f85ca76a3581a92feb6556228ec3216a987ad369:

builds and tests overall are FAILURE.
Build with configuration of
gcc-12.1.0/clangis FAILURE, :bar_chart:clang report (full)/(new), build logBuild with configuration of
gcc-12.1.0/newis FAILURE, :bar_chart:Compiler report (full)/(new), build logBuild with configuration of
gcc-12.1.0/scanis FAILURE, :bar_chart:scan-build report (full)/(new), build logcpp-checkis SUCCESS, :bar_chart:cppcheckreport (full)/(new)
Automatically generated by sPHENIX Jenkins continuous integration

Build & test report
Report for commit 9e8c44f442adc93e721dbec5c9c83db83bc0a3b2:

builds and tests overall are FAILURE.
Build with configuration of
gcc-12.1.0/clangis FAILURE, :bar_chart:clang report (full)/(new), build logBuild with configuration of
gcc-12.1.0/newis FAILURE, :bar_chart:Compiler report (full)/(new), build logBuild with configuration of
gcc-12.1.0/scanis FAILURE, :bar_chart:scan-build report (full)/(new), build logcpp-checkis SUCCESS, :bar_chart:cppcheckreport (full)/(new)
Automatically generated by sPHENIX Jenkins continuous integration

I had a look at the failure - we cannot have any dependencies on other libraries here. That can be overcome by moving those classes to ffarawobjects. But looking at this - with the pooling where the time ordering of the data is preserved this should really not be necessary anymore