coresoftware

coresoftware copied to clipboard

sPHENIX-Collaboration

Reame
Issues

use phi size of padplane readout sectors from TPC_FEE_CHANNEL_MAP

Open mitrankova opened this issue 1 year ago • 7 comments

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work for users)
[ ] Requiring change in macros repository (Please provide links to the macros pull request in the last section)
[x] I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Jul 26 '24 21:07 mitrankova

Build & test report

Report for commit 5634ec10eb3fe35ff1d5cd6d5cee2cdcd6d2a7b4:

builds and tests overall are FAILURE.
Build with configuration of gcc-12.1.0 / clang is FAILURE, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
Build with configuration of gcc-12.1.0 / scan is FAILURE, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Jul 27 '24 01:07 sphenix-jenkins-ci[bot]

Build & test report

Report for commit 579abeed9ac317b1bf25cea92028a3e572267eee:

builds and tests overall are FAILURE.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 45.6147 / 72, and combined p-Value = 0.993571
  - :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 24.6126 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.9499 / 42, and combined p-Value = 0.937089
  - :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 63.1178 / 42, and combined p-Value = 0.0191034
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 609.153 / 56, and combined p-Value = 6.12553e-94
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 90.9874 / 56, and combined p-Value = 0.0021564
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 72.3563 / 112, and combined p-Value = 0.998658
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 75.1546 / 56, and combined p-Value = 0.0447178
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 37.1057 / 50, and combined p-Value = 0.911875
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 31.2413 / 112, and combined p-Value = 1
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is UNSTABLE, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Jul 27 '24 19:07 sphenix-jenkins-ci[bot]

Hi Mariia, don't worry about the failures - I am using your PR to try a few things. Once I am done I'll merge this

Jul 27 '24 19:07 pinkenburg

Build & test report

Report for commit 5530dd303a6b46f046db5b3a2ce4e537bc6541a4:

builds and tests overall are FAILURE.
Build with configuration of gcc-12.1.0 / clang is SUCCESS, :bar_chart:clang report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, :bar_chart:Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 45.6147 / 72, and combined p-Value = 0.993571
  - :bar_chart: QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 24.6126 / 72, and combined p-Value = 1
  - :bar_chart: QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.9499 / 42, and combined p-Value = 0.937089
  - :bar_chart: QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 63.1178 / 42, and combined p-Value = 0.0191034
- Tracking QA with Distortions: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 611.513 / 56, and combined p-Value = 2.08789e-94
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 90.9874 / 56, and combined p-Value = 0.0021564
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 72.3563 / 112, and combined p-Value = 0.998658
- Tracking QA for Pythia D0-jet: build is SUCCESS, :bar_chart: trends
  - :bar_chart: QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - :bar_chart: QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - :bar_chart: QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - :bar_chart: QA-Tpc : combined Chi2/nDoF = 75.4194 / 56, and combined p-Value = 0.0428111
  - :bar_chart: QA-tracking : combined Chi2/nDoF = 37.1057 / 50, and combined p-Value = 0.911875
  - :bar_chart: QA-vertexing : combined Chi2/nDoF = 31.2534 / 112, and combined p-Value = 1
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year1.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year1.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, :bar_chart:valgrind report, trends :bar_chart:
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system gcc-12.1.0, build new: Valgrind test: build is UNSTABLE, :bar_chart:valgrind report, trends :bar_chart:
Build with configuration of gcc-12.1.0 / scan is SUCCESS, :bar_chart:scan-build report (full)/(new), build log
clang-tidy is SUCCESS, :bar_chart:clang-tidy report (full)/(new)
cpp-check is SUCCESS, :bar_chart:cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Jul 27 '24 23:07 sphenix-jenkins-ci[bot]

The valgrind error is just a shifted line number of a known issue, it's now in the suppression file

Jul 28 '24 02:07 pinkenburg

Yes, these modifications correct the max and min sector positions in phi to the ones that are corresponding to the CDB values. However, it doesn't change the residuals much. Probably these are not all the modifications that are needed. I am trying to confirm it now.

Jul 30 '24 21:07 mitrankova

Okay I will hold off on merging this then. It may be good to double check with Evgeny, as he was seeing a lot of unusual changes in the simulation residuals (but maybe that issue has been resolved)

Jul 31 '24 01:07 osbornjd