Steve Pieper
Steve Pieper
Yes, this would be good to clean up 👍
> Would you accept a PR for such a feature? Sounds reasonable to me, so long as it's backwards compatible and uses basically standard web features.
I don't see any downside to being more tolerant when reading. It might make sense to try reading first, and if an exception is raised issue a warning and try...
From the documentation for `force`, it says it only checks for a metaheader, which I would think is very quick. But we could check if it's an issue.
There's a test failing. CoPilot says it's due to unicode for mm2, can you look into making the tests pass? In general I'm good with this but haven't looked at...
Thanks for providing the examples, @abhijith-trenser , this helps a lot. I tried this with Slicer 5.10.0 and the latest Quantitative Reporting extension. It's not surprising that it's not working...
>> ... appearance or UI-related elements like (TextPosition, 99CS3D, "Text Annotation Position"). > I KNOW this isn't in keeping with the recommendation for semantic meaning only, but storing this in...
Yes, when I agree with the logic that the old way was not right and the new looks correct. It's not a very widely used code path so it's not...
> Would it be possible to add an entry to our documentation to provide some background ? Some suggested wording here: https://github.com/Slicer/Slicer/pull/8756
From a quick look I think the PR looks good 👍 I'd like another set of eyes on it though, so hopefully @wayfarer3130 can take a look too.