Steve Pieper

Results 685 comments of Steve Pieper

Looks nice 👍 Yes, you can force-push to your branch to update the PR.

I would love to see a consistent approach to concurrency in the slicer core libraries, and starting with IO makes a lot of sense. I had done experiments before with...

+1 for exposing cmake build options and other build status cleanly available at runtime. I think there are probably many situations where we'd want to know things like which flags...

We already have this logic: https://github.com/Slicer/Slicer/blob/c0d0b9ee9dc6a65e8ca4f4e6cf7d4d248632f727/Modules/Scripted/WebServer/WebServer.py#L230-L231 Which I believe could be added here in the `__init__` too, since DICOM should be loaded before WebServer (or we could enforce that). https://github.com/Slicer/Slicer/blob/c0d0b9ee9dc6a65e8ca4f4e6cf7d4d248632f727/Modules/Scripted/WebServer/WebServerLib/__init__.py#L2...

I tried taking out those lines, and a few other places where Courier is mentioned but no luck, the message still appears.

Following the suggestion from @jcfr above, setting the filter flag works. On my mac build: Running as-is we get the message ``` (base) pieper@hive sr % ./Slicer-build/Slicer Switch to module:...

Thanks for the investigation @pedrokohler. If we can get it to work, I think option 2, streaming, is the best. Regarding point 3, can you try doing a HEAD request...

Interesting, thanks for checking this @pedrokohler . It looks like you checked a QIDO studies endpoint. I wonder if a WADO request for ANN data would behave the same. Just...

Oh, okay. Then I guess it's a limitation of the dicomweb implementation. I'm not sure if there's anything in the standard about whether this should be supported or not. Maybe...

Thanks @pedrokohler - that makes sense but it was worth trying. Another thing that might help is that we should be able to get progress events from the dicomweb-client to...