Steve Pieper

Results 685 comments of Steve Pieper

It sounds very useful. I'll be curious to hear what others think about this. @lassoan @sam @ebrahimebrahim @jcfr

Thanks for raising and working on this. I haven't got much experience with multiple encodings, but from what I understand it should be quite localized to the encoding/decoding of a...

That's okay - I think the issue you pointed to (#373) is definitely a limitation in dcmjs and it would be great for someone to work on it someday. Glad...

@luissantosHCIT yes, I think it would make sense for those mappings to be exposed. Probably also `encapsulatedSyntaxes` and `singleVRs`. Looking now from that perspective they might belong in the meta...

I don't see any reason you couldn't express that. You could look at how it's done in dcmqi and add it. https://github.com/search?q=repo%3AQIICR%2Fdcmqi%20mean&type=code I'm okay if people want to add more...

+1 for not limiting to VTK or Volume Rendering. These could easily be shared with OHIF, which already uses Slicer presets (via vtk.js). But I prefer the SlicerPresets branding since...

@fedorov from a quick look I think @wayfarer3130 is not overwriting the SR instance, but adding the new instance to the same series as existing SRs. I don't know if...

Note that there is this section in the script repository: https://slicer.readthedocs.io/en/latest/developer_guide/script_repository.html#batch-processing

Nitpick: Please include deep links to the code instead of copying the code inline. E.g. here's the code in the repo: https://github.com/dcmjs-org/dcmjs/blob/167de51c745ed1f697783abc053ac5b3e33726f4/src/ValueRepresentation.js#L345-L362

Definitely OX and XS handling should be fixed. These are VRs where the type is only known in the context of the rest of the file. Rather than throwing a...