Steve Pieper

Results 556 comments of Steve Pieper

I don't really know how that metadataProvider is supposed to work (maybe the API is documented somewhere about what you can expect it to provide and what not, but I...

As noted in #375 there hasn't been much testing or development with compressed images so if the results are incorrect someone would need to debug. It shouldn't be much work...

Hi @emelalkim thanks for your patience - I think the issue is that `MediaStorageSOPInstanceUID` is only supposed to be in the part10 (dicom file) metaheader and not in the dataset...

Hmm, either 2.25.xxx or 1.3.xxx should be fine. There are rules in the standard about what's allowed in these strings of numbers but software like dcmjs shouldn't care. (We use...

I'm glad you found a good solution @emelalkim. I agree it's not clear if this requires a change in the library.

Thanks for reporting 👍 For background, when you report an issue, it helps to include a link to the code you are referring too (e.g. [like this](https://github.com/dcmjs-org/dcmjs/blob/f844e025f86055a918c13269f6d762a711f3a4bf/src/Tag.js#L51). You can also...

Hi - thanks for the report and for sharing the data. Can you post the error message you get? Would you be okay with this data being added to https://github.com/dcmjs-org/data...

That sounds very reasonable - I don't know that anyone has plans to work on that, but if you wanted to suggest a backwards compatible way to do that it...

Thanks for pointing this out - would you be able to provide a pull request with the fixes?

Thanks for the report and the file. Did you figure out what's different about this data? Will you be able to look into a fix?