Steve Pieper

Results 541 comments of Steve Pieper
trafficstars

I like the idea but are `core` and `base` clear enough? Maybe something like `MRMLITK` to be explicit about what dependency is being introduced.

I believe vtkITK plays a different role than the other to methods you pointed to @jcfr - they both provide classes for converting between vtkImageData and itk::Image so you can...

Yes, this is a great idea. Can they be backward compatible or does this need to be a new format?

Okay, then we should version it somehow like with a new file extension. It sounds like this would be a useful format to try to promote for tools like dcmqi,...

👍 for standardizing and clearly the meaning of the color files. Perhaps that meaning can have more than one standardized representation (i.e. json and csv - and dicom SEG?) with...

This is ready for review if people want to make comments. But per our discussion at the last developer call we'll hold off merging until after the 5.6 release.

> how to auto-select the just loaded file in user interface? Probably easiest to use this utility to show the images in the background: https://github.com/Slicer/Slicer/blob/main/Base/Python/slicer/util.py#L514

+1 for being more explicit either in the naming convention or in giving the user the ability to specify the load pattern. I agree that heuristics can be painful.

> _Assuming the pull-request was unintentionally closed, I am re-opening it so that we further improve and reach consensus._ Yes - sorry, wrong button!

Thanks for working on this 👍