Phil Jones

Results 75 comments of Phil Jones

I think the test failure is unrelated to these changes.

This linter will run over the files you run flake8 over there is nothing special to do after installing. [This documentation](https://flake8.pycqa.org/en/latest/user/using-plugins.html) may help.

Hmm, I'm not sure here - it could be. Could you confirm which version it worked in, and which version you are using now?

I think it is the exists (and also this https://github.com/pgjones/flake8-sql/commit/d1a1000e870db0c3fd88cf5e5c7a62c33aad51d8) - as the exists isn't being recognized as a function.

Very happy for you to send a fix, at the moment I can only point to d1a1000.

It is available as part of the `server` key passed as part of the asgi scope

These usually indicate that a task has been cancelled and not awaited. I think I managed to find all these in Hypercorn so I'd suspect elsewhere - do you have...

I didn't think `LifespanFailure` would be used outside of the Hypercorn code directly - I'd like to learn about your usage. It is a renaming, I'll add it to the...

I'm not sure that these errors should leak out to the middleware - I guess this is an app that doesn't support lifespans?