hypercorn icon indicating copy to clipboard operation
hypercorn copied to clipboard

Published 20 hours ago • verified publisher icon pgjones

h11_max_incomplete_size marked as HTTP/2 in documentation

Open touilleMan opened this issue 2 years ago • 1 comments

In the documentation: image

However h11_max_incomplete_size is used in h11 (so HTTP 1.1 support): https://github.com/pgjones/hypercorn/blob/8cef567301a5a3f4363d1c2cad76008e58add8aa/src/hypercorn/protocol/h11.py#L96

touilleMan avatar Jun 10 '22 07:06 touilleMan

Also it would be good to document the default values for the various limits in the documentation, cf. https://github.com/pgjones/hypercorn/blob/8cef567301a5a3f4363d1c2cad76008e58add8aa/src/hypercorn/config.py#L75-L78

Would you accept a PR on this ?

touilleMan avatar Jun 10 '22 07:06 touilleMan

I'd very much welcome PRs on these

pgjones avatar Aug 28 '22 17:08 pgjones