Phil Jones

Results 75 comments of Phil Jones

Note that if async coroutines are connected to any signal's `receiver_connected` or `receiver_disconnected` there will be a runtime error. I think this is acceptable.

I also prefer this approach, however as it more of a preference question I'll wait for more views.

I do plan to get to this, but I need to find a bit more time given I don't understand it yet. Thank you for looking into this and the...

I think the issue here is that wsproto doesn't accept (by typing) a `h11.Headers` instance as an argument to `initiate_upgrade_connection`. I think this is correct as I don't think `h11.Headers`...

Thanks, I've managed to find time to understand the problem - but I'm not sure about the solution. It would be helpful if @Lukasa could comment on the general solution...

Looks like the pypy3 gh action version is 3.6, rather than 3.7 or higher.

> Looks like the pypy3 gh action version is 3.6, rather than 3.7 or higher. Now fixed by being explicit.

Python3.6 is now long passed it's end of life and 3.11 is due soon, time to merge.