Vadim Petrochenkov

Results 259 comments of Vadim Petrochenkov

So it looks like `-Zsanitizers` does 2 things - affects codegen - affects linking (adds some libraries) And the effect of both https://github.com/rust-lang/rust/pull/121420 and this PR is that the linking...

It looks like this use-case is different from `-Clink-self-contained` after all. Maybe something like `-Zsanitizers=msan,nolink` or a separate option like https://github.com/rust-lang/rust/pull/121207 would be more suitable.

@bjorn3 Could you - Split https://github.com/rust-lang/rust/pull/120855/commits/2eb24d9d154eda645bf25fdef2107d2dad215cf5 into a separate PR in case it causes regressions - Split all preparatory refactorings like https://github.com/rust-lang/rust/pull/120855/commits/1065559b2e07d540b7752f7cfa7b2ed1c43177a1 into a separate PR - Rebase the remaining...

I removed one fast path optimization for simplicity, so let's also run benchmarks. @bors try @rust-timer queue

# Stabilization Report Before this PR all spans coming from macro definitions were by default collapsed to a single span representing the macro's call site when generating debuginfo. The option...

@jackh726 > My only (soft) concern is that `collapse-macro-debuginfo` has not sat for very long (and I guess the no/external/yes options are also fairly new, but I'm less concerned about...

@azhogin > Could it be better to change cmd/attr table (unspecified + unspecified = if-ext) instead of changing default attribute to `external`? ![cmd_attr_table](https://private-user-images.githubusercontent.com/44302620/305046200-3e7851ec-753c-4b8b-afab-d94b0c827d20.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDgwMDU3NTEsIm5iZiI6MTcwODAwNTQ1MSwicGF0aCI6Ii80NDMwMjYyMC8zMDUwNDYyMDAtM2U3ODUxZWMtNzUzYy00YjhiLWFmYWItZDk0YjBjODI3ZDIwLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjE1VDEzNTczMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ1MmJlNGYxMzlhN2Q1MGQwMjk1Mjg4NzcyZWRmYWQ2ZmRiOGMzZDE3NTE5MTIwZjI2NWIxMzI0ZDVmYTZlNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.AEnEUYYDop2QZ2Sbaup9Gb96qduefN7ktfLU2koHJ1I) The end result is the same, no?...