Vadim Petrochenkov
Vadim Petrochenkov
So it looks like `-Zsanitizers` does 2 things - affects codegen - affects linking (adds some libraries) And the effect of both https://github.com/rust-lang/rust/pull/121420 and this PR is that the linking...
It looks like this use-case is different from `-Clink-self-contained` after all. Maybe something like `-Zsanitizers=msan,nolink` or a separate option like https://github.com/rust-lang/rust/pull/121207 would be more suitable.
@bjorn3 Could you - Split https://github.com/rust-lang/rust/pull/120855/commits/2eb24d9d154eda645bf25fdef2107d2dad215cf5 into a separate PR in case it causes regressions - Split all preparatory refactorings like https://github.com/rust-lang/rust/pull/120855/commits/1065559b2e07d540b7752f7cfa7b2ed1c43177a1 into a separate PR - Rebase the remaining...
cc @davidtwco @azhogin
I removed one fast path optimization for simplicity, so let's also run benchmarks. @bors try @rust-timer queue
Perf changes are noise. @bors rollup=maybe
# Stabilization Report Before this PR all spans coming from macro definitions were by default collapsed to a single span representing the macro's call site when generating debuginfo. The option...
@rfcbot fcp merge
@jackh726 > My only (soft) concern is that `collapse-macro-debuginfo` has not sat for very long (and I guess the no/external/yes options are also fairly new, but I'm less concerned about...
@azhogin > Could it be better to change cmd/attr table (unspecified + unspecified = if-ext) instead of changing default attribute to `external`?  The end result is the same, no?...