Vadim Petrochenkov

I still dislike that it deviates from the conventions used for all other platforms. I mean, moving linking to libcore, not adding `/defautlib`, `/defautlib` could be added to libc equally...

Yeah, mingw is one of the few exceptions, and it links libraries from the target spec (which is as wrong as linking them from libcore, IMO). I wanted to remove...

Ok, maybe its fine, if producing a linked binary requires some analogue of "crt objects", and on MSVC they are merged together with the rest of libc into a single...

Hmmm. r? @RalfJung

I think it's fine to land this as an ICE first and then think what to do next when some actual examples of that ICE are found in practice. @bors...

@bors r+

Let's run benchmarks first, to check whether it will perform as horribly as it looks, with all the repeated crate visiting and AST cloning. @bors try @rust-timer queue

> https://github.com/rust-lang/rust/pull/122165#issuecomment-1989364344 Yep, pretty bad.

In general, I'd like to see the whole unused import pass to be rewritten. The existing removal span collection logic (working on AST) was added without much consideration for the...

So how I'd expect the `check_unused` pass to work at high level: - First we walk all lowered imports in the crate, using `for module in self.arenas.local_modules().iter() { ... }`,...