Vadim Petrochenkov

Results 259 comments of Vadim Petrochenkov

Need to link to https://github.com/rust-lang/compiler-team/issues/727 from this PR description. @rustbot author

Implementation LGTM, except the commit message needs to be more human oriented. I'm going to pass this to r? @traviscross in cases some additional lang team approval is needed, but...

Summary: - https://github.com/rust-lang/rust/pull/120706 introduces a way to add new auto traits that are appended to all bound lists by default, similarly to existing `Sized`. Such traits may include `Leak`, `SyncDrop`...

The right strategy here is for `println!` (and other similar macros) to do what `#[cfg_accessible(path)]` currently does - Attempt to resolve `a` (or rather attempt to expand `a!()`) - If...

What this PR does may be helpful too, but it's sort of luck based. We try to resolve imports one last time just before eagerly expanding a macro, and if...

So, the current approach clearly won't work. @rustbot author

r=me with https://github.com/rust-lang/rust/pull/121589#discussion_r1521886941 addressed.

Thanks! Fixing this was in my todo list for quite some time. @bors r+

I didn't have a chance to look at the changes yet, I'll do it later this week, most likely.