Vadim Petrochenkov
Vadim Petrochenkov
Effective visibility changes look ok. `unused-warnings` and `libc` are stress tests for effective visibilities, so they will regress a bit if `FxIndexMap` is any slower than `FxHashMap`.
The syntax of the option is a bit weird. Maybe keep the `-L KIND=PATH` but add a "magic variable" that would expand into the necessary directory like `$ORIGIN` in rpaths?...
Implementation LGTM, I'll mark this as waiting on bikeshed for a few days.
@Veykril I've just noticed that this feature ended up being insta stable. Could you make it require `-Zunstable-options`? In theory, this should need an FCP to get to stable. (And...
The milestone is [1.79.0](https://github.com/rust-lang/rust/milestone/118), so it looks like it's not in beta yet.
Some high level comments: This PR adds many lang items, it would be good to document not just what they do, but why are they added - to avoid generating...
This needs a review from someone who maintains MIR building/passes/transforms. It's quite possible that some things here are not done idiomatically, and could be done simpler/better. I oversaw this work,...
@traviscross Summary: - Larger compiler team MCP including this feature - https://github.com/rust-lang/compiler-team/issues/727, it gives some more context - "Async drop glue" partially implemented in this PR allows to automatically generate...
@Nilstrieb I'll make a compiler team MCP for core components for async drop enabling library experimentation soon. @traviscross is currently the Async WG liaison for this stuff (I actually assumed...