Vadim Petrochenkov

Results 259 comments of Vadim Petrochenkov

TODO: Also need to check whether these `HirId`s could be removed instead, maybe they are not really necessary and were added by mistake.

> TODO: Also need to check whether these `HirId`s could be removed instead, maybe they are not really necessary and were added by mistake. The `HirId` in `Let` turned out...

https://github.com/rust-lang/rust/pull/120206#discussion_r1461195337 helped to identify one more class of stray `HirId`s in import list stems. They weren't detected previously because they were always at the end of `nodes` lists. This case...

Let's talk about one of the hard problems in CS. ### Linker flavor naming #### The base component is unfortunately needed It would be nice to just drop the base...

@rustbot ready (on the design, not implementation)

>- a possibly nice thing I wasn't anticipating with the clang flavor is they'd simplify our wasm targets specs (it's maybe one of the WIP bits of the PR, as...

>- I find the *idea* of generic flavors ... So, I thought maybe we should do a 180 degree turn and shift *all* the logic except principal flavors to `-Clinker-features`?...

>It feels like it should simplify our current setup, and this PR's flavors of course, but were you also imagining using this for the generic flavors? (I don't think so?)...