Peter Schwartz

Results 152 comments of Peter Schwartz

@BunnyVon My fix of just checking "use_cn" worked for the production run test suite but was insufficient for FATES test with ECA in particular since they also have `use_cn =...

I'll try merging this again with the latest changes. Here were the tests that had DIFFs or NLFAILs (some unrelated to this PR) from the e3sm_developer test. Including the list...

@jenniferholm To clarify, the `nu_com = 'RD'` wasn't removed as a case -- it is still the default value for nu_com in the source code (elm_varctl.F90) and the namelist. This...

I've merged to my local next branch and am just waiting on test suite results.

merged to next

Merged to master.

The error is that some decomp_cascade_con fields are allocated starting from 0 but the corresponding fields for the elm interface data types are allocated starting at 1. `elm_interface_bgc_datatype:` `allocate(this%decomp_pool_name (1:ndecomp_pools))...

@rljacob There is a dedicated parameter `spval=1.E+36` that is used for that purpose. Typically arrays will be initialized to `spval` when they're added to the history field list. So this...

Yes, this is inefficient -- I'm guessing since the code was written before the filters were implemented. (Like how all local arrays are allocated based on the bounds rather than...