E3SM icon indicating copy to clipboard operation
E3SM copied to clipboard

fates api 24

Open rgknox opened this issue 2 years ago • 1 comments

This set of changes enables coupling with FATES API 24. This introduces the ability of FATES to dictate the number of veg-patches used on the natural land unit, an updated FATES parameter file format, hooks to enable fates wood harvest product fluxes, and hooks for a new crown damage module.

rgknox avatar Jul 21 '22 14:07 rgknox

land developer tests on cori pass: /global/cscratch1/sd/rgknox/e3sm_tests/E2ba9fa8333-Fdef6b3e7-fates-api24-v2

All fates tests have expected NLCOMP and BASELINE differences All non-fates tests are B4B with base with some timing differences which I believe are due to machine performance variability

rgknox avatar Jul 23 '22 19:07 rgknox

Thanks for comments @bishtgautam , I think I've addressed them

rgknox avatar Aug 12 '22 18:08 rgknox

@rgknox Is this PR BFB?

bishtgautam avatar Aug 12 '22 18:08 bishtgautam

I can. This module is in progress in FATES, we do plan on having a test for it.

rgknox avatar Aug 12 '22 20:08 rgknox

@bishtgautam , removed the damage test defs

rgknox avatar Aug 18 '22 14:08 rgknox

@bishtgautam is this ready to merge?

rljacob avatar Aug 25 '22 17:08 rljacob

I've merged to my local next branch and am just waiting on test suite results.

peterdschwartz avatar Aug 25 '22 17:08 peterdschwartz

merged to next

peterdschwartz avatar Aug 30 '22 20:08 peterdschwartz

Merged to master.

peterdschwartz avatar Aug 31 '22 18:08 peterdschwartz