Peter Schwartz

Results 152 comments of Peter Schwartz

Got rid of carbon imbalances from all but FATES configs. The FATES issue isn't from my recent PR as checking out `b633fd5f2680a0ee434213d5b4d39b363d18ef81` and fixing the mistake with `GridCBalanceCheck` produces those...

Take a look at this branch: https://github.com/peterdschwartz/E3SM/commits/peterdschwartz/lnd/fix-balance-errors/

@glemieux I made some changes based on your thoughts and the one FATES test does PASS now. I don't understand why FATES needs to set different carbon inputs, but here...

Ok, no more FAILs nor DIFFs for my branch. I'll rebase to run the newly added tests, and if that's good, make a PR with this fix and a few...

Merged to next. Expecting these DIFFs in the TCS and TWS variables ``` ERS.r05_r05.ICNPRDCTCBC.pm-cpu_intel.elm-cbudget (Overall: DIFF) details: SMS_Ly2_P1x1.1x1_smallvilleIA.IELMCNCROP.pm-cpu_intel.elm-force_netcdf_pio (Overall: DIFF) details: SMS_Ly2_P1x1_D.1x1_smallvilleIA.IELMCNCROP.pm-cpu_intel.elm-lulcc_sville (Overall: DIFF) details: ```

since @rljacob went ahead and approved, that I'll go ahead with the merge today unless there are any objections.

Merged to next. Expect DIFFs due to FIELD LIST for any tests that compare elm.h0 files.

Merged to master. hopefully got all the DIFFs

` ERS_D.ne4pg2_oQU480.I20TRELM.chrysalis_intel.elm-disableDynpftCheck` FAILs when I merged this to next ``` 4: decompInit_lnd(): Number of clumps exceeds number of land grid cells 4: 256 201 25: decompInit_lnd(): Number of clumps exceeds...