Peter Schwartz

Results 152 comments of Peter Schwartz

After doing a test merge I obtained FILLDIFF for the `fates_cold_allvars`. That I need to look into today

Quick update: `fates_cold_allvars` FAILs at the `COMP_base_rest` stage. The cprnc file just shows `CMASS_BALANCE_ERROR` with very small differences. Since there are no other diffs (i.e., in variables used to calculate...

Not baseline diff (though that is also there but makes sense to me). It fails the COMP_base_rest portion of ERP test (same thing with the ERS version I made for...

REP passes just fine. I'm going to double check that each variable for carbon balance is read/written to the restart file, and maybe a longer simulation will reveal diff's accruing...

status: `fates_cold_allvars` still fails restart test. Tried adding every gridcell and column variable related to CMASS_BALANCE to history and restart files but no other differences. Tried running test for 2...

@rljacob I met with @glemieux a couple of weeks ago. He mentioned a possible time-step dependent part of FATES that could be the cause, but I think he's been busy...

Update: Increasing output freq finally showed a new diff in a field. Looking into it further, it appears that the vertical transport tendency terms for carbon are not added to...

@glemieux This [Code block](https://github.com/E3SM-Project/E3SM/blob/master/components/elm/src/data_types/ColumnDataType.F90#L7531) is what I was referring to. The transport tendency is not added to carbon leached pool even though the corresponding terms are added for Nitrogen and...

Since there's a previous fates related issue linked above with the same errors, I'm going to just clean the branch up for the other issues and follow the review comments....

@rgknox I don't have permissions to view your testing directory, but I ran your branch after merging to next on chrysalis and go a DIFF in `SMS_Ld20.f45_f45.IELMFATES.chrysalis_intel.elm-fates_eca`. Looking at the...