Peter Schwartz

E3SM Land Developer Tests Failing in DEBUG Mode

16

With current master, I ran many of the land developer tests in debug mode ( case directory is here: /lcrc/group/e3sm/ac.schwartzpd/master-debug-tests/cases) and it seems any that use the chemistry of ELM...

prep_rof_mrg using non-associated and un-allocated pointer O2R_RX

6

While working on another issue, my debug runs would fail in `prep_rof_mod` with the below traceback, which has happened with all debug land tests that I've tried so far on...

Fix C balance and FPE errors

14

Carbon balance was never checked correctly and let through negative values. Initialization of Ecosystem variables needed to be re-adjusted, and balance checking for FATES needed to be changed, which causes...

Carbon Imbalance with CN runs

14

Discovered that `GridCBalanceCheck` doesn't use absolute value when error checking so negative imbalances can propagate through the Land Model. [Line is here](https://github.com/E3SM-Project/E3SM/blob/master/components/elm/src/biogeochem/EcosystemBalanceCheckMod.F90#L961C14-L961C26) Running `e3sm_land_developer` test suite after changing to absolute...

P Balance error with ECA not checked due to unassigned nstep variable

2

Issue discovered while trying to clean up EcosystemDyn initialization. In EcosystemBalanceCheckMod.F90, the routine `ColPBalanceCheck` never assigns the `nstep` variable (used [here](https://github.com/E3SM-Project/E3SM/blob/master/components/elm/src/biogeochem/EcosystemBalanceCheckMod.F90#L736C38-L736C38) ). Proper assignment of `nstep` results in `ERS.f19_g16.I1850CNECACTCBC.chrysalis_intel.elm-eca` test...

Replace `>0._r8` check in CH4Mod with a small parameter set by `tiny` intrinsic function. The exact value of `tiny(1._r8)` may depend on the compiler and machine but is on the...

decomp carbon pools are not calculated as expected

1

The code block in question is here: [ColumnDataType.F90 L7533](https://github.com/E3SM-Project/E3SM/blob/master/components/elm/src/data_types/ColumnDataType.F90#L7533) ``` if (use_pflotran .and. pf_cmode) then ! note: the follwoing should be useful to non-pflotran-coupled, but seems cause 1 BFB test...

Intermittent failure of MOSART and elm.cbudget tests on mappy

3

ERS.r05_r05.IELM.mappy_gnu.elm-V2_ELM_MOSART_features will alternate between FAIL and DIFF with the below error message. ``` profile sums: 1.0000000000000000 1.0000000000000000 1.0000000000000000 0.99923994737367017 ENDRUN: ERROR: sum-1 > deltaERROR in /home/e3sm-jenkins/jenkins-ws/workspace/mappy_e3sm_master/E3SM/components/elm/src/biogeochem/VerticalProfileMod.F90 at line 340 ERROR:...

refactor 1 of elm routines for openacc

5

SoilLittVertTransp changes: decrease memory allocations, incorporate list for decomp variables initialized at run start. Adjusted p2c_1d subroutines to include OpenACC directives Included OpenACC versions for Nitrogen and Phosphorus dynamics. Refactored...

fix stream full_file mode

3

The `"full_file" `read mode for streams appears to have stopped being supported at some point. After looking at all the stream settings, I could not figure out a way to...