Peter Barker

> HOWEVER, it seems very specific to APM and does not follow the Mavlink spec and so does not work with PX4 or other flight controllers that do follow the...

> I have managed to worked around the issue on the drone side, however I still believe if `MAV_CMD_DO_SET_MODE_is_supported` is set then it should support the Mavlink standard which uses...

@muramura as @IamPete1 points out, the underlying type in the structure is float, not integer. The cast to float would have been added to fix the compilation error which said...

> The number of characters is checked above, is it actually possible for the read to fail here? If so that’s certainly a gotcha that needs to be documented. Technically...

There are still comments on here that haven't been addressed, and it would be nice if more things in the CI suite passed :-)

> Can we document the return value? UARTDriver.h does not say that 0 is a failure. 0 is not failure - it really is `\0`. `->read()` returns `int16_t` and you...

> Bitfields are not documented in AP_Logger/README.md The parameter documentation in general is not documented in there.

Patches do look likely. Should be a single commit with title something like , `AP_Scripting: provide bindings for parity and stop bits` @tpwrules is this likely to work as-is?

``` Board AP_Periph blimp bootloader copter heli iofirmware plane rover sub Durandal 0 * 0 0 -8 0 0 HerePro -2616 Hitec-Airspeed * KakuteH7-bdshot 0 * 0 0 8 0...

I've updated this branch so it's no-changes across the board, near enough, when RangeFinder is still enabled: ``` Board AP_Periph blimp copter heli plane rover sub CubeOrange-periph-heavy -768 MatekL431-Proximity -688...