ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

Lua serial parity stopbits

Open ajboainain opened this issue 9 months ago • 3 comments

Adds Lua scripting support to configure UART parity and stop bits through the AP_Scripting_SerialAccess interface.

Changes Added configure_parity(uint8_t) and set_stop_bits(uint8_t) methods to AP_Scripting_SerialAccess

Updated bindings.desc with proper type validation and range limits

Updated docs.lua for Lua API documentation

Needs further testing. If someone can test on my behalf I would be very grateful, as I am on vacation now.

ajboainain avatar Jun 03 '25 13:06 ajboainain

Patches do look likely.

Should be a single commit with title something like , AP_Scripting: provide bindings for parity and stop bits

@tpwrules is this likely to work as-is?

peterbarker avatar Jun 04 '25 08:06 peterbarker

Patches do look likely.

Should be a single commit with title something like , AP_Scripting: provide bindings for parity and stop bits

@tpwrules is this likely to work as-is?

Noted. I'll try to squash the commits and chance the message.

ajboainain avatar Jun 04 '25 11:06 ajboainain

OK. Squashed the commits into 1 commit and added correct format for commit message as requested.

ajboainain avatar Jun 04 '25 17:06 ajboainain

Looks good overall, tested on Cube Orange that at least all the parity settings work.

Please clean up the return values and then we can merge. Be sure to squash your fix into the original commit.

Noted. Changes have been made. Thank you so much for testing, @tpwrules !

ajboainain avatar Jun 07 '25 21:06 ajboainain